catch rate-limiting errors and fix other error-parsing for api key validation#63
Merged
catch rate-limiting errors and fix other error-parsing for api key validation#63
Conversation
pfvatterott
approved these changes
Jan 22, 2025
Contributor
pfvatterott
left a comment
There was a problem hiding this comment.
Tested yesterday, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR
Before this PR, all error responses from the BE when validating an end-user api key were getting flattened into
ApiKeyError::UnknownError. Now we catch the validation or rate limiting error with the data returned from the PropelAuth. Example use:Tests
Verified all expected behavior within an example application.
Note
See here for a description of all the possible BE error responses.